[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable. Create g
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable. Create get_ticks_per_sec() function |
Date: |
Fri, 11 Sep 2009 11:37:02 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Juan Quintela wrote:
> Jan Kiszka <address@hidden> wrote:
>> Juan Quintela wrote:
>>> Signed-off-by: Juan Quintela <address@hidden>
>> [...]
>>
>>> diff --git a/vl.c b/vl.c
>>> index 448ec6c..33abef2 100644
>>> --- a/vl.c
>>> +++ b/vl.c
>>> @@ -186,7 +186,7 @@ enum vga_retrace_method vga_retrace_method =
>>> VGA_RETRACE_DUMB;
>>> static DisplayState *display_state;
>>> DisplayType display_type = DT_DEFAULT;
>>> const char* keyboard_layout = NULL;
>>> -int64_t ticks_per_sec;
>>> +static int64_t ticks_per_sec;
>>> ram_addr_t ram_size;
>>> int nb_nics;
>>> NICInfo nd_table[MAX_NICS];
>>> @@ -1032,6 +1032,11 @@ int64_t qemu_get_clock(QEMUClock *clock)
>>> }
>>> }
>>>
>>> +int64_t get_ticks_per_sec(void)
>>> +{
>>> + return ticks_per_sec;
>>> +}
>>> +
>> This refactoring would be even more useful if that one became
>>
>> static inline int64_t get_ticks_per_sec(void)
>> {
>> return QEMU_CLOCK_BASE;
>> }
>>
>> Right now we don't have a use for the ticks_per_sec /variable/, it's
>> always constant. Your interface does not prevent changing this in the
>> future, though, which is just like it should be.
>
> I liked this one on top.
Why?
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
- Re: [Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable. Create get_ticks_per_sec() function, (continued)
- Re: [Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable. Create get_ticks_per_sec() function, Amit Shah, 2009/09/11
- Re: [Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable. Create get_ticks_per_sec() function, Markus Armbruster, 2009/09/11
- Re: [Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable. Create get_ticks_per_sec() function, Anthony Liguori, 2009/09/11
- [Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable. Create get_ticks_per_sec() function, Juan Quintela, 2009/09/11
- [Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable. Create get_ticks_per_sec() function, Jan Kiszka, 2009/09/11
- [Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable. Create get_ticks_per_sec() function, Juan Quintela, 2009/09/10
- [Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable. Create get_ticks_per_sec() function, Paolo Bonzini, 2009/09/10
- [Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable. Create get_ticks_per_sec() function, malc, 2009/09/10
[Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable. Create get_ticks_per_sec() function, Jan Kiszka, 2009/09/11
[Qemu-devel] [PATCH 07/26] timers: move them to VMState, Juan Quintela, 2009/09/09
[Qemu-devel] [PATCH 08/26] vmstate: add sensible arguments to vmstate_unregister(), Juan Quintela, 2009/09/09
[Qemu-devel] [PATCH 09/26] vmstate: rename run_after_load() -> post_load(), Juan Quintela, 2009/09/09
[Qemu-devel] [PATCH 10/26] vmstate: Add pre_load() hook, Juan Quintela, 2009/09/09
[Qemu-devel] [PATCH 11/26] vmstate: Add pre/post_save() hooks, Juan Quintela, 2009/09/09
[Qemu-devel] [PATCH 12/26] vmstate: port cpu_comon, Juan Quintela, 2009/09/09
[Qemu-devel] [PATCH 14/26] vmstate: port i8259 device, Juan Quintela, 2009/09/09
[Qemu-devel] [PATCH 13/26] vmstate: port fw_cfg device, Juan Quintela, 2009/09/09