[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/20] VMState: port all i2c devices
From: |
Juha.Riihimaki |
Subject: |
Re: [Qemu-devel] [PATCH 00/20] VMState: port all i2c devices |
Date: |
Fri, 11 Sep 2009 12:31:30 +0200 |
Hi,
On Sep 11, 2009, at 13:10, ext Juan Quintela wrote:
> - i2c->address now are uint8_t, my review of all uses is that they
> are always
> used as uint8_t (and that is the type that is passed on the
> value). If you know
> i2c, please check. Change 0002 looks big, but it is because as I was
I would propose that the address has more than 8 bits to be more
future-proof. After all, the bus addressing has already been extended
to 10 bits: see http://www.i2c-bus.org/addressing/10-bit-addressing/
Regards,
Juha
- [Qemu-devel] [PATCH 07/20] vmstate: port wm8750 device, (continued)
- [Qemu-devel] [PATCH 07/20] vmstate: port wm8750 device, Juan Quintela, 2009/09/11
- [Qemu-devel] [PATCH 12/20] vmstate: create VMSTATE_INT16_ARRAY, Juan Quintela, 2009/09/11
- [Qemu-devel] [PATCH 08/20] vmstate: port max7310 device, Juan Quintela, 2009/09/11
- [Qemu-devel] [PATCH 10/20] vmstate: port pxa2xx_i2c device, Juan Quintela, 2009/09/11
- [Qemu-devel] [PATCH 13/20] tmp105: change len and alorm to uint8_t, Juan Quintela, 2009/09/11
- [Qemu-devel] [PATCH 14/20] vmstate: port wmp105 device, Juan Quintela, 2009/09/11
- [Qemu-devel] [PATCH 16/20] vmstate: port twl92230 device, Juan Quintela, 2009/09/11
- [Qemu-devel] [PATCH 17/20] vmstate: add support for arrays of pointers, Juan Quintela, 2009/09/11
- [Qemu-devel] [PATCH 19/20] vmstate: port lm832x device, Juan Quintela, 2009/09/11
- [Qemu-devel] [PATCH 11/20] vmstate: port ssd0303 device, Juan Quintela, 2009/09/11
- Re: [Qemu-devel] [PATCH 00/20] VMState: port all i2c devices,
Juha.Riihimaki <=
- [Qemu-devel] [PATCH 15/20] twl92230: change pwrbtn_state to uint8_t, Juan Quintela, 2009/09/11
- [Qemu-devel] [PATCH 20/20] vmstate: remove i2c_slave_load/save, Juan Quintela, 2009/09/11
- [Qemu-devel] [PATCH 18/20] lm832x: make fields to have the same types that they are saved/loaded, Juan Quintela, 2009/09/11