Re: [Qemu-devel] [PATCH 1/8] qdev/pci: add pci_create_noinit()

[Gerd Hoffmann]

> > -PCIDevice *pci_create_simple(PCIBus *bus, int devfn, const char *name)
> > +PCIDevice *pci_create_noinit(PCIBus *bus, int devfn, const char *name)
> >   {
> >       DeviceState *dev;
> >
> >       dev = qdev_create(&bus->qbus, name);
> >       qdev_prop_set_uint32(dev, "addr", devfn);
> > -    qdev_init(dev);
> > +    return DO_UPCAST(PCIDevice, qdev, dev);
> > +}
>
> Okay, this is qdev_create() specialized for PCI.  What about calling it
> just pci_create()?

pci_create() should go away once it has no more users.  It doesn't 
accept a pcibus parameter as it should.

cheers,
  Gerd