qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/12] cpuid: cleanup and some enhancements


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 0/12] cpuid: cleanup and some enhancements
Date: Mon, 14 Sep 2009 12:08:16 -0500
User-agent: Thunderbird 2.0.0.23 (X11/20090825)

Andre Przywara wrote:
Hi,

the following patchset cleans up CPUID bit handling and adds some smaller
features.
The most prominent change is to move all CPUID related functions to a
separate file. About 40% of helper.c was actually CPUID related, so say
hello to cpuid.c. While at it, I fixed some formatting issues. (Patch 1-5)
Patch 6 & 7 add the CPUID feature flag names to the output of -cpu ?.
Patch 8 & 9 simplify some code.
Patch 10 allows more CPUID leafs to be propagated to guests when -cpu host
is used, this should now reflect the host CPU's cache size.
Patch 11 adds a trimming feature (similar to KVM) to QEMU/TCG. The goal
is to describe CPU models more precisely by reflecting the feature bits of
the real hardware. Features that QEMU does not support are then masked.
If we add features to QEMU, we only need to adjust it in one location.
I will send a patch fixing the CPU models later.
Patch 12 adjusts the size of the L2 cache described by leaf 4 to a more
conservative value of one megabyte. This prevents guests assuming too large
caches if they use optimized algorithms.

This series breaks the build for non-i386 targets as it unconditionally adds cpuid.o to libqemu even though that file only exists for target-i386.

Regards,

Anthony Liguori

Please review, comment and apply!
Thanks and Regards,
Andre.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]