[Qemu-devel] Re: optional feature

[Michael S. Tsirkin]

On Wed, Sep 16, 2009 at 03:34:21PM +0200, Juan Quintela wrote:
> "Michael S. Tsirkin" <address@hidden> wrote:
> > On Wed, Sep 16, 2009 at 03:01:22PM +0200, Juan Quintela wrote:
> >> >> > pci config is on vmstate already, I don't see a problem here.
> >> >> 
> >> >> vmstate don't understand pci config.
> >> >
> >> > How can it save it then? What's more, how can it load it sanely? E.g.
> >> > when loading we must make sure that device id etc match.
> >> 
> >> We don't test it at all.
> >
> > Someone has to. Existing code has it.  Removing this sanity check and
> > changing e.g. device id by load will be a bad thing.
> 
> Is there anything else that the code that I posted in the other email?
> I didn't removed any check.

Sorry, I thought you were advocation replacing get_pci_config_device.
If you are happy with it as it is, no problem.

-- 
MST