[Qemu-devel] Re: [PATCH 2/7] monitor: Handle new and old style handlers

[Paolo Bonzini]

>   The problem is that the monitor_handler_ported() branch can
> have additional code in the future (eg. protocol emission code),
> so different branches makes things easier to understand.

Well, you don't know... It may end up in different functions, like

void print_cmd_result_user (Monitor *mon, MonitorCmd *cmd, int result,
                            QObject *data)
{
        if (result)
                ...
        else if (cmd->user_print)
                cmd->user_print (mon, data);
}

void print_cmd_result_json (Monitor *mon, MonitorCmd *cmd, int result,
                            QObject *data)
{
        ... make qdict with result and data ...
        qdict_print_json (mon->something, output_dict);
        qobject_decref (output_dict);
}

or it may end up not being a branch (but an indirect function call) for 
example:

        result = handler_new (mon, qdict, &data);
        mon->print_cmd_result (mon, cmd, result, data);
        if (data)
                qobject_decref (data);

I'd stay with the simplest thing for now.  I'm not going to argue, 
especially if I'm overridden by other reviewers, of course.

Paolo

Paolo