Re: [Qemu-devel] [PATCH 4/5] serial: convert isa to qdev

[Gerd Hoffmann]

On 09/18/09 17:04, Markus Armbruster wrote:
> Gerd Hoffmann<address@hidden>  writes:
>
> > Signed-off-by: Gerd Hoffmann<address@hidden>
> > ---
> >   hw/mips_malta.c |    4 +-
> >   hw/mips_r4k.c   |    6 +---
> >   hw/pc.c         |    6 +---
> >   hw/pc.h         |    1 +
> >   hw/ppc_prep.c   |    3 +-
> >   hw/serial.c     |   77 +++++++++++++++++++++++++++++++++++++++++++++++-------
> >   hw/sun4u.c      |    6 +---
> >   7 files changed, 75 insertions(+), 28 deletions(-)
>
> Stupid question: how did you figure out which serials are ISA?

Look at I/O ports + irq windup.

> > +    s->baudbase = 115200;
>
> The initial baudbase.  Used to be defined as argument to serial_init(),
> but all arguments were 115200.  Okay.

Yea.  Was a bit sloppy with commit messages on this series, guess it 
needs a respin just because of that ...

cheers,
  Gerd