Re: [Qemu-devel] [PATCH] Set SDL icon_title when using `-name XXX` for proper gnome-panel window list integration

[Dustin Kirkland]

On Thu, Sep 17, 2009 at 7:05 PM, Dustin Kirkland
<address@hidden> wrote:
> On Thu, Sep 17, 2009 at 10:25 AM, Anthony Liguori <address@hidden> wrote:
>> Dominic Evans wrote:
>>>
>>> qemu: improve sdl title information
>>>
>>> Include the `-name XXX` commandline param in the gnome-panel window list
>>> via icon_title.
>>>
>>> https://bugs.edge.launchpad.net/ubuntu/+source/qemu-kvm/+bug/423076
>>>
>>
>> Please include a Signed-off-by.
>
> Hmm, I tested this patch for inclusion in Ubuntu.  It seems to work (-name 
> foo).
>
> However, it seems to either break, or expose a bug in libvirt:
>
> Traceback (most recent call last):
>  File "/usr/share/virt-manager/virtManager/engine.py", line 493, in run_domain
>    vm.startup()
>  File "/usr/share/virt-manager/virtManager/domain.py", line 558, in startup
>    self.vm.create()
>  File "/usr/lib/python2.6/dist-packages/libvirt.py", line 293, in create
>    if ret == -1: raise libvirtError ('virDomainCreate() failed', dom=self)
> libvirtError: internal error unable to start guest: /usr/bin/kvm:
> invalid option -- '-domid'
>
> I haven't quite made sense of this yet...  -domid is not a valid
> parameter in kvm, sure.  However, when launching VM's in virt-manager
> with this patch, this is the behavior I'm seeing...

Sorry, I take this back.  My testing was not in a clean environment.

Dominic's patch works for me.  I'm adding it to the Ubuntu qemu-kvm
package.  Hopefully it will be accepted upstream for 0.12.

Tested-by: Dustin Kirkland <address@hidden>