[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 0/7] Remove pre ANSI c89 code
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH 0/7] Remove pre ANSI c89 code |
Date: |
Wed, 23 Sep 2009 01:18:58 +0200 |
Hi
In commemoration of the 20th anniversary of the c89 standard, this brings
qemu codebase to c89. How do I know?
Previous to last patch adds to QEMU_CFLAGS:
-Wold-style-declaration -Wold-style-definition
Why?
- typedef abuse for the 1st patch. How that ever worked, I don't know.
- gcc gets picky, and you have to declare functions as:
static inline void f(...)
inline static void f(...)
but
static void inline f(...)
gets warnings. Just move the few functions that have the third
format to the 1st one.
- bring alpha-dis.c and sh4-dis.c to ansi c89 function declaration.
- static + const: gcc wants you to use:
static const
and gives a warning for
const static
- same for static + __thread (only 1 occurrence)
- last patch removes PARAMS() from dis-asm.h
last users were alpha-dis.c and sh4-dis.c (do you start to see a
pattern here).
Last one is not required, but as qemu is not going to compile in pre-c89
compiler any time soon, it is better to also apply it.
Later, Juan.
Juan Quintela (7):
Use proper typedef syntax
static and inline should came before the type of the functions
Bring two last users of K&R definitions to ANSI c89
gcc wants 1st static and then const
__thread should be before real type
Add -Wold-style-declaration -Wold-style-definition to QEMU_CFLAGS
Remove PARAMS() macro
alpha-dis.c | 116 ++++++++++++-------------------------
configure | 1 +
dis-asm.h | 102 ++++++++++++++++-----------------
gen-icount.h | 2 +-
hw/g364fb.c | 4 +-
hw/pflash_cfi01.c | 2 +-
hw/serial.c | 4 +-
hw/sh7750.c | 2 +-
hw/usb-bt.c | 2 +-
hw/xen_blkif.h | 4 +-
linux-user/arm/nwfpe/fpa11_cprt.c | 2 +-
linux-user/mmap.c | 2 +-
sh4-dis.c | 32 +++-------
target-i386/kvm.c | 2 +-
target-microblaze/translate.c | 4 +-
target-ppc/translate.c | 8 +-
16 files changed, 116 insertions(+), 173 deletions(-)
- [Qemu-devel] [PATCH 0/7] Remove pre ANSI c89 code,
Juan Quintela <=
- [Qemu-devel] [PATCH 4/7] gcc wants 1st static and then const, Juan Quintela, 2009/09/22
- [Qemu-devel] [PATCH 2/7] static and inline should came before the type of the functions, Juan Quintela, 2009/09/22
- [Qemu-devel] [PATCH 1/7] Use proper typedef syntax, Juan Quintela, 2009/09/22
- [Qemu-devel] [PATCH 3/7] Bring two last users of K&R definitions to ANSI c89, Juan Quintela, 2009/09/22
- [Qemu-devel] [PATCH 5/7] __thread should be before real type, Juan Quintela, 2009/09/22
- [Qemu-devel] [PATCH 6/7] Add -Wold-style-declaration -Wold-style-definition to QEMU_CFLAGS, Juan Quintela, 2009/09/22