[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] comments on: get page size in device init
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] comments on: get page size in device init |
Date: |
Wed, 23 Sep 2009 15:58:18 +0300 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
> Compile msix only once
>
> Get page size in device init.
>
> Signed-off-by: Blue Swirl <address@hidden>
What was the motivation for the page size change?
It seems the only user passes TARGET_PAGE_SIZE anyway,
using a constant seems clearer and probably generates
less code. No?
Did I miss this patch on qemu-devel? Generally, it's nice to have
patches posted to list to give people a chance to comment, before they
are pushed to the public tree. Right?
Finally, the 2 changes seem unrelated: why was it a good idea to bundle
them in one commit?
Thanks,
--
MST
- [Qemu-devel] comments on: get page size in device init,
Michael S. Tsirkin <=