|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] [PATCH 3/4] virtio-console: Add support for multiple ports for generic guest-host communication |
Date: | Wed, 23 Sep 2009 15:04:27 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3 |
-device virtio-console Creates the portbus master. No ports (yet). -device vmport-console,chardev=$dev Creates a port named 'org.qemu.console' and links it to $dev.OK; that's what I have now, slightly different: -device virtio-console-pci -device virtconport,port=0,chardev=$dev
Fine as well. The exact names don't really matter, the naming for the port drivers should be consistent though (i.e. have the same prefix for all of them or something like that). Optional port number looks reasonable too. Should default to auto-allocation if not specified.
For backward-compatibility we'll allways have to create a vmport-console at port 0, so there will never be a virtio-console without a port. That is a minor bit we can fixup once the above works fine.ie -virtioconsole<chardev> ?
There are two kinds of backward compatibility ;) One is the qemu command line. The other is the ABI for old guest drivers. The later requires a console at port 0 ...
I'd suggest we just drop that in 0.12.
Dropping the command line switch is with me. In case someone disagrees (libvirt folks?) it isn't hard to maintain compatibility though.
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |