[Qemu-devel] Re: comments on: get page size in device init

[Anthony Liguori]

Blue Swirl wrote:
> On Wed, Sep 23, 2009 at 3:58 PM, Michael S. Tsirkin <address@hidden> wrote:
>   
> > >     Compile msix only once
> > >
> > >     Get page size in device init.
> > >
> > >     Signed-off-by: Blue Swirl <address@hidden>
> > >       
> > What was the motivation for the page size change?
> >     
>
> "Compile msix only once"
>
>   
> > It seems the only user passes TARGET_PAGE_SIZE anyway,
> > using a constant seems clearer and probably generates
> > less code. No?
> >     
>
> Yes, but then the code would depend on TARGET_PAGE_SIZE, making it
> impossible to compile the code only once.
>   

We could probably get away with doing

#define TARGET_PAGE_SIZE target_get_page_size()

And take care of a big chunk of this without passing page size 
parameters around.

Regards,

Anthony Liguori