Re: [Qemu-devel] [PATCH 4/5] serial: convert isa to qdev

[Markus Armbruster]

Gerd Hoffmann <address@hidden> writes:

> Everything using standard isa I/O ports and IRQ windup is considerd
> being an actual isa device.  That are all serial_init() users except
> mips_mipssim() which seems to have a non-standard IRQ windup.
>
> baud rate is fixed at 115200 now as no caller passed in something else.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>  hw/mips_malta.c |    4 +-
>  hw/mips_r4k.c   |    6 +---
>  hw/pc.c         |    6 +---
>  hw/pc.h         |    1 +
>  hw/ppc_prep.c   |    3 +-
>  hw/serial.c     |   77 +++++++++++++++++++++++++++++++++++++++++++++++-------
>  hw/sun4u.c      |    6 +---
>  7 files changed, 75 insertions(+), 28 deletions(-)
>
[...]
> diff --git a/hw/ppc_prep.c b/hw/ppc_prep.c
> index cb7167e..889284a 100644
> --- a/hw/ppc_prep.c
> +++ b/hw/ppc_prep.c
> @@ -685,7 +685,8 @@ static void ppc_prep_init (ram_addr_t ram_size,
>      //    pit = pit_init(0x40, i8259[0]);
>      rtc_init(2000);
>  
> -    serial_init(0x3f8, i8259[4], 115200, serial_hds[0]);
> +    if (serial_hds[0])
> +        serial_isa_init(0, serial_hds[0]);
>      nb_nics1 = nb_nics;
>      if (nb_nics1 > NE2000_NB_MAX)
>          nb_nics1 = NE2000_NB_MAX;

Why the new conditional?  Bug fix perhaps?

[...]