qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCHv2] qemu: target library, use it in msix


From: Blue Swirl
Subject: [Qemu-devel] Re: [PATCHv2] qemu: target library, use it in msix
Date: Thu, 24 Sep 2009 20:50:11 +0300

On Wed, Sep 23, 2009 at 11:06 PM, Michael S. Tsirkin <address@hidden> wrote:
> This creates target.c, which builds per-target, and makes it possible
> for devices to become target-independent.  Use it in msix, reverting
> part of 5e520a7d500ec2569d22d80f9ef4272a34cb3c80, as we no longer have
> to pass target page around.

> +unsigned target_page_align(unsigned value)
> +{
> +       return TARGET_PAGE_ALIGN(value);
> +}

This must be:
target_phys_addr_t target_page_align(target_phys_addr_t value)

As this is not a clean revert anyway, please don't revert the part changing
if (x)
 y;
else
 z;

to

if (x) {
 y;
} else {
 z;
}




reply via email to

[Prev in Thread] Current Thread [Next in Thread]