[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/13] convert pci bridge to qdev
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH 06/13] convert pci bridge to qdev |
|
Date: |
Thu, 24 Sep 2009 20:29:56 +0200 |
|
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) |
"Michael S. Tsirkin" <address@hidden> writes:
> On Tue, Sep 22, 2009 at 11:29:20AM +0200, Gerd Hoffmann wrote:
>> @@ -890,15 +890,12 @@ PCIDevice *pci_find_device(int bus_num, int slot, int
>> function)
>> return bus->devices[PCI_DEVFN(slot, function)];
>> }
>>
>> -PCIBus *pci_bridge_init(PCIBus *bus, int devfn, uint16_t vid, uint16_t did,
>> - pci_map_irq_fn map_irq, const char *name)
>> +static int pci_bridge_initfn(PCIDevice *dev)
>
> pci_bridge_dev_init a better name?
There's precedence for _initfn, _init1, and _init. I wish we'd pick one
convention and stick to it.
[...]
- Re: [Qemu-devel] [PATCH 12/13] pci: move unregister from PCIDevice to PCIDeviceInfo, (continued)
[Qemu-devel] [PATCH 09/13] Add exit callback to DeviceInfo., Gerd Hoffmann, 2009/09/22
[Qemu-devel] [PATCH 13/13] usb: hook unplug into qdev, cleanups + fixes., Gerd Hoffmann, 2009/09/22
[Qemu-devel] [PATCH 06/13] convert pci bridge to qdev, Gerd Hoffmann, 2009/09/22
[Qemu-devel] [PATCH 08/13] qdev: device free fixups., Gerd Hoffmann, 2009/09/22
[Qemu-devel] [PATCH 11/13] pci: use qdev for device destruction., Gerd Hoffmann, 2009/09/22
Re: [Qemu-devel] [PATCH 00/13] qdev: bus management updates., Markus Armbruster, 2009/09/24