Re: [Qemu-devel] [PATCH] Fix exit on 'pci_add' Monitor command

[Mark McLoughlin]

On Thu, 2009-09-24 at 20:12 +0200, Markus Armbruster wrote:
> My major complaint is that I'd rather see the code cleaned up there.
> It's perfectly fine for code that can run only during startup to
> terminate the program on configuration error.  Code to be used after
> startup (used from monitor, in particular) must not do that.  Instead,
> it should return failure up the call chain, until we reach either
> startup code or monitor code, where the policy how to handle the error
> resides.

Agree, I'd like to see it cleaned up.

However, Luiz's patch fixes the most serious side effect without a major
re-factoring, so I'd like to see that go in first (and stable-0.11) and
do the re-factoring later.

Cheers,
Mark.