qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 07/13] piix_pci: kill PIIX3IrqState


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 07/13] piix_pci: kill PIIX3IrqState
Date: Fri, 25 Sep 2009 09:24:28 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3

  Hi,

-    b = pci_register_bus(&s->busdev.qdev, "pci.0",
-                         piix3_set_irq, pci_slot_get_pirq, irq_state, 0, 4);
+    b = pci_bus_new(&s->busdev.qdev, NULL, 0);

Passes null name to pci_bus_new().  Intentional?  Before, we passed
"pci.0" to pci_register_bus().

Yes. qbus_create() will construct a name for you, which happens to be "pci.0". So we don't need to pass it in. Having "pci.0" in there was just temporary needed due to the order patches where merged.

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]