[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] unbreak usb pass-through on linux.
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] unbreak usb pass-through on linux. |
Date: |
Fri, 25 Sep 2009 16:31:10 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Fri, Sep 25, 2009 at 02:15:34PM +0200, Gerd Hoffmann wrote:
> Changes:
> * Re-add the 'dev->fd = fd;' line which the qdev patches dropped
> by mistake.
> * call qdev_init() so the newly created usb device is plugged into
> a usb port and thus actually visible to the guest.
> ---
> usb-linux.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
Good work. A SoB is missing though.
> diff --git a/usb-linux.c b/usb-linux.c
> index c434e4f..2b7b092 100644
> --- a/usb-linux.c
> +++ b/usb-linux.c
> @@ -922,6 +922,7 @@ static USBDevice *usb_host_device_open_addr(int bus_num,
> int addr, const char *p
>
> dev->bus_num = bus_num;
> dev->addr = addr;
> + dev->fd = fd;
>
> /* read the device description */
> dev->descr_len = read(fd, dev->descr, sizeof(dev->descr));
> @@ -979,6 +980,7 @@ static USBDevice *usb_host_device_open_addr(int bus_num,
> int addr, const char *p
>
> hostdev_link(dev);
>
> + qdev_init(&d->qdev);
> return (USBDevice *) dev;
>
> fail:
> --
> 1.6.2.5
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net