Re: [Qemu-devel] Main loop

[Blue Swirl]

On Sun, Sep 27, 2009 at 2:55 AM, malc <address@hidden> wrote:
>
> At http://repo.or.cz/w/qemu/malc.git?a=shortlog;h=refs/heads/mtloop you
> can find the branch which refactors main execution loop somewhat, effects
> include:
>
> a. Host alarm timers are gone
> b. IO thread is replaced (now Windows is supported too)
>
> I have no means of testing the KVM/Xen bits (both are likely to be broken
> by this), and since testing was only done on Linux/X86-64[1],PPC and
> Windows/i386 chances are good that something might be not so great in
> BSD/Solairs/MacOS X lands.
>
> Apart from obvious KVM bits, other things were not implemented (yet)
> either: proper VM stop/resume, GDB, etc.
>
> Diffstat relative to c2b023b62707f5dc73497dc03f3764f145a29785 (plus
> one somewhat unrelated local commit) is bellow.
>
>  Makefile        |    1 -
>  configure       |    8 -
>  cpu-defs.h      |    2 -
>  cpu-exec.c      |    3 +
>  hw/xenfb.c      |    2 +-
>  qemu-options.hx |    9 -
>  qemu-thread.c   |  163 ------
>  qemu-thread.h   |   40 --
>  sysemu.h        |    2 +-
>  vl.c            | 1650 
> ++++++++++++++++++++-----------------------------------
>  10 files changed, 593 insertions(+), 1287 deletions(-)
>
> Comments?

+extern void ontb (CPUState *env);
+

Please try to avoid prototypes outside header files. The name does not
tell what the function does.

     if (delta < MIN_TIMER_REARM_US)
         delta = MIN_TIMER_REARM_US;
+    if (delta > MIN_TIMER_REARM_US)
+        delta = MIN_TIMER_REARM_US;

The above four lines are equal to
     delta = MIN_TIMER_REARM_US;

Maybe the latter two should use MAX_TIMER_REARM_US?