[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state
From: |
malc |
Subject: |
[Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state |
Date: |
Wed, 30 Sep 2009 15:47:17 +0400 (MSD) |
On Wed, 30 Sep 2009, Juan Quintela wrote:
> malc <address@hidden> wrote:
> > On Tue, 29 Sep 2009, Juan Quintela wrote:
> >
> >> This simplifies reset_voices, that only takes one argument now.
> >>
> >> Signed-off-by: Juan Quintela <address@hidden>
> >> ---
> >> hw/ac97.c | 42 ++++++++++++++++++++----------------------
> >> 1 files changed, 20 insertions(+), 22 deletions(-)
> >>
> >> diff --git a/hw/ac97.c b/hw/ac97.c
> >> index 610ca60..da6cb2d 100644
> >> --- a/hw/ac97.c
> >> +++ b/hw/ac97.c
> >> @@ -146,6 +146,13 @@ typedef struct AC97BusMasterRegs {
> >> BD bd;
> >> } AC97BusMasterRegs;
> >>
> >> +enum {
> >> + PI_INDEX = 0,
> >> + PO_INDEX,
> >> + MC_INDEX,
> >> + LAST_INDEX
> >> +};
> >
> > And this was moved becasue...?
>
> Because I need LAST_INDEX in next part that you quoted.
Ah, missed that, yes.
> >> +
> >> typedef struct AC97LinkState {
> >> PCIDevice dev;
> >> QEMUSoundCard card;
> >> @@ -162,6 +169,7 @@ typedef struct AC97LinkState {
> >> uint8_t silence[128];
> >> uint32_t base[2];
> >> int bup_flag;
> >> + uint8_t active[LAST_INDEX];
> >
> > This doesn't belong here, cause the only purpose i can see is to hack
> > around defficiencies of the new load/savevm APIs.
>
> That was supposed to be one of the features, not deficiences. You can't
> sent stuff that it is not in the state. It is "by design" that you can't
> sent arbitrary variables.
active doesn't belong in the above structure, it's not used for anything
other than save/loadvm. If this "design" doesn't allow this, either find
another way to accomplish the same or fix the "design".
--
mailto:address@hidden
- [Qemu-devel] [PATCH 20/49] twl92230: change pwrbtn_state to uint8_t, (continued)
- [Qemu-devel] [PATCH 20/49] twl92230: change pwrbtn_state to uint8_t, Juan Quintela, 2009/09/29
- [Qemu-devel] [PATCH 21/49] vmstate: port twl92230 device, Juan Quintela, 2009/09/29
- [Qemu-devel] [PATCH 24/49] vmstate: port lm832x device, Juan Quintela, 2009/09/29
- [Qemu-devel] [PATCH 22/49] vmstate: add support for arrays of pointers, Juan Quintela, 2009/09/29
- [Qemu-devel] [PATCH 23/49] lm832x: make fields to have the same types that they are saved/loaded, Juan Quintela, 2009/09/29
- [Qemu-devel] [PATCH 25/49] vmstate: remove i2c_slave_load/save, Juan Quintela, 2009/09/29
- [Qemu-devel] [PATCH 26/49] vmstate: port audio/audio.c, Juan Quintela, 2009/09/29
- [Qemu-devel] [PATCH 27/49] ac97: add active to the state, Juan Quintela, 2009/09/29
- Re: [Qemu-devel] [PATCH 27/49] ac97: add active to the state, malc, 2009/09/30
- [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, Juan Quintela, 2009/09/30
- [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state,
malc <=
- [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, Juan Quintela, 2009/09/30
- [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, malc, 2009/09/30
- [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, Juan Quintela, 2009/09/30
- [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, malc, 2009/09/30
- [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, Juan Quintela, 2009/09/30
- [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, malc, 2009/09/30
- [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, Juan Quintela, 2009/09/30
- [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, malc, 2009/09/30
- [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, Juan Quintela, 2009/09/30
- Re: [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state, Anthony Liguori, 2009/09/30