|
From: | Paul Brook |
Subject: | Re: [Qemu-devel] Re: [PATCH 0/2] fix virtio_blk serial pci config breakage |
Date: | Wed, 30 Sep 2009 12:47:46 +0100 |
User-agent: | KMail/1.12.1 (Linux/2.6.30-1-amd64; KDE/4.3.1; x86_64; ; ) |
> > But the rationale that got us here was from the > > user's perspective this information could be > > trivially exposed via a preexisting interface vs. > > creating a new interface as I'd done initially. > > It was also pointed out other defined fields in > > the identify page exist which were potentially > > useful. So pressing a HDIO_GET_IDENTITY ioctl > > into service here didn't seem unreasonable. > > virtio-blk isn't an ATA device so why pretend like it is? Agreed. If we're going to copy anything than my vote would be for SCSI. We already have partial support for feeding SCSI commands to a virtio device. TBH I wouldn't have bothered with virtio-blk at all, and gone straight for virtio-scsi. I guess it's a bit late for that though. Paul
[Prev in Thread] | Current Thread | [Next in Thread] |