[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 25/61] pci: use uint64_t for bar addr and size i
From: |
Isaku Yamahata |
Subject: |
Re: [Qemu-devel] [PATCH 25/61] pci: use uint64_t for bar addr and size instead of uint32_t. |
Date: |
Thu, 1 Oct 2009 14:34:23 +0900 |
User-agent: |
Mutt/1.5.6i |
On Wed, Sep 30, 2009 at 06:55:51PM +0400, malc wrote:
> On Wed, 30 Sep 2009, Isaku Yamahata wrote:
>
> > This patch is preliminary for 64bit bar.
> > For 64bit bar support, replace uint32_t with uint64_t for addr/size
> > to be able to represent 64bit.
>
> I'm not sure how this supposed to work with devices that are physically
> incapable of working with 64bit addresses, care to explain?
Such a device implements only 32bit BAR and never 64bit BAR.
So it gets only 32bit addressable value in uint64_t.
If you want to make sure it, you can insert
assert(address <= UINT32_MAX) into map function of such devices.
--
yamahata
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 25/61] pci: use uint64_t for bar addr and size instead of uint32_t.,
Isaku Yamahata <=