Re: [Qemu-devel] [PATCH 4/9] pci: use uint64_t for bar addr and size instead of uint32_t.

[malc]

On Thu, 1 Oct 2009, Michael S. Tsirkin wrote:

> On Thu, Oct 01, 2009 at 04:15:59PM +0400, malc wrote:
> > On Thu, 1 Oct 2009, Michael S. Tsirkin wrote:
> > 
> > > On Wed, Sep 30, 2009 at 09:59:11PM +0400, malc wrote:
> > > > On Wed, 30 Sep 2009, Michael S. Tsirkin wrote:
> > > > 

[..snip..]

> 
> In practice I don't expect any posix header to clash with
> michael_s_tsirkin_t even though in theory it might.
> 
> So you can choose not to use any types that end with _t and have a
> guarantee that you won't clash with posix, and just name types sanely so
> they don't clash with posix in practice, on any platform people care
> about, like 99% of the world does.
> 
> > similarly identifiers that start with 'str', 'E', double
> > underscore and underscore followed by a capital letter are reserved by
> > C, you just don't go there.
> 
> I agree, double underscores look ugly enough to avoid them without a special
> reason, but for everyone reading C, *_t means "scalar type"
> and this benefit of using it outweights, IMO, the danger of
> potential clash with a header on a non-existing platform.

That's that basically - we disagree.

-- 
mailto:address@hidden