qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH v2][SEABIOS] Move qemu config port access functi


From: Gleb Natapov
Subject: [Qemu-devel] Re: [PATCH v2][SEABIOS] Move qemu config port access functions into separate file.
Date: Sun, 4 Oct 2009 15:06:49 +0200

On Sun, Oct 04, 2009 at 09:01:09AM -0400, Kevin O'Connor wrote:
> On Sun, Oct 04, 2009 at 11:09:07AM +0200, Gleb Natapov wrote:
> > 
> > Move qemu config code from smbios.c to its own files. Add support for
> > -boot menu=on|off qemu option.
> 
> Thanks Gleb.
> 
> Please rename the "pv" files - at a minimum to "paravirt", although I
> think "qemucfg" or "emucfg" is more appropriate.
> 
I want to put things like kvm_para_available() there too. qemucfg naming
suggest that this is only qemu fw_cfg driver, but I want it to be more.
I'll rename it to paravirt.[ch]

> The other thing is new ".c" files need a one line description and a
> copyright at the top.  If you don't care about the copyright then just
> reuse Fabrice's from smbios.c.
> 
> If you wish, I can make these changes.
> 
I'll resend.

--
                        Gleb.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]