[Qemu-devel] Re: [PATCH 03/25] pci: introduce constant PCI_NUM_PINS for the number of interrupt pins, 4.

[Isaku Yamahata]

On Sun, Oct 04, 2009 at 12:04:53PM +0200, Michael S. Tsirkin wrote:
> On Sat, Oct 03, 2009 at 05:15:55AM +0900, Isaku Yamahata wrote:
> > introduce constant PCI_NUM_PINS for the number of interrupt pins, 4.
> > and use it.
> > 
> > Signed-off-by: Isaku Yamahata <address@hidden>
> 
> Acked-by: Michael S. Tsirkin <address@hidden>
> 
> > ---
> >  hw/pci.c |    4 ++--
> >  hw/pci.h |    4 +++-
> >  2 files changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/hw/pci.c b/hw/pci.c
> > index d281ee2..40035e6 100644
> > --- a/hw/pci.c
> > +++ b/hw/pci.c
> > @@ -177,7 +177,7 @@ const VMStateDescription vmstate_pci_device = {
> >          VMSTATE_INT32_LE(version_id, PCIDevice),
> >          VMSTATE_SINGLE(config, PCIDevice, 0, vmstate_info_pci_config,
> >                         typeof_field(PCIDevice,config)),
> > -        VMSTATE_INT32_ARRAY_V(irq_state, PCIDevice, 4, 2),
> > +        VMSTATE_INT32_ARRAY_V(irq_state, PCIDevice, PCI_NUM_PINS, 2),
> 
> By the way, what is 2 standing for, here?
> The macro definition isn't really informative:
>       #define VMSTATE_INT32_ARRAY_V(_f, _s, _n, _v)                         \
>           VMSTATE_ARRAY(_f, _s, _n, _v, vmstate_info_int32, int32_t)
> 
> /me wishes for less multi-parameter macros: { .blabla = 2 } would be
> clearer ...

It is a version of save/load format.
Perhaps Juan Quintela could answer more detailed.
-- 
yamahata