[Qemu-devel] Re: [PATCH] qemu/pci: clarify pci config load routine

[Juan Quintela]

"Michael S. Tsirkin" <address@hidden> wrote:
> PCI load routine has to be called with size equal to 256 (otherwise it
> will crash in weird ways).  So assert this,

Agreed with the assert().

> making code clearer.
> Also avoid dynamically sized array on stack - good for portability.

size has the right value, namely sizeof(PCIDevice.config).  Only real
advantage is that you are not using a dynamically sized array on the
stack.

I don't care one way or another.  And as you are more probable to touch
that code than me, it is up to you :)

Later, Juan.