[Qemu-devel] Re: [PATCH 12/23] pci: 64bit bar support.

[Isaku Yamahata]

On Mon, Oct 05, 2009 at 02:47:11PM +0200, Michael S. Tsirkin wrote:
> > @@ -462,7 +474,11 @@ static void pci_update_mappings(PCIDevice *d)
> >                  }
> >              } else {
> >                  if (cmd & PCI_COMMAND_MEMORY) {
> > -                    new_addr = pci_get_long(d->config + config_ofs);
> > +                    if (pci_bar_is_mem64(r)) {
> > +                        new_addr = pci_get_quad(d->config + config_ofs);
> 
> From previous patch, config_ofs is region_num * 4
> This is incorrect for 64 bit regions.

I don't see any problems. In the following example, 
0, 2 ... will be used for region_number and 1 is left unused.

BAR0 64bit memory
BAR1 used by BAR0 64bit
BAR2 ...
-- 
yamahata