[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] Port usb net to QemuOpts
From: |
Mark McLoughlin |
Subject: |
[Qemu-devel] [PATCH] Port usb net to QemuOpts |
Date: |
Tue, 6 Oct 2009 12:17:14 +0100 |
We need net_client_init_from_opts() exported for this
Signed-off-by: Mark McLoughlin <address@hidden>
---
net.c | 2 +-
net.h | 2 ++
vl.c | 19 +++++++++++++++----
3 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/net.c b/net.c
index 1ebf147..c8c8c78 100644
--- a/net.c
+++ b/net.c
@@ -3001,7 +3001,7 @@ static struct {
{ /* end of list */ }
};
-static int net_client_init_from_opts(Monitor *mon, QemuOpts *opts)
+int net_client_init_from_opts(Monitor *mon, QemuOpts *opts)
{
const char *type;
int i;
diff --git a/net.h b/net.h
index a2d5b3c..27a1c50 100644
--- a/net.h
+++ b/net.h
@@ -4,6 +4,7 @@
#include "qemu-queue.h"
#include "qemu-common.h"
#include "qdict.h"
+#include "qemu-option.h"
/* VLANs support */
@@ -136,6 +137,7 @@ extern const char *legacy_tftp_prefix;
extern const char *legacy_bootp_filename;
int net_client_init(Monitor *mon, const char *device, const char *p);
+int net_client_init_from_opts(Monitor *mon, QemuOpts *opts);
void net_client_uninit(NICInfo *nd);
int net_client_parse(const char *str);
int net_slirp_smb(const char *exported_dir);
diff --git a/vl.c b/vl.c
index 811f26d..70d1aed 100644
--- a/vl.c
+++ b/vl.c
@@ -2593,12 +2593,23 @@ static int usb_device_add(const char *devname, int
is_hotplug)
dev = usb_baum_init();
#endif
} else if (strstart(devname, "net:", &p)) {
- int nic = nb_nics;
+ QemuOpts *opts;
+ int idx;
- if (net_client_init(NULL, "nic", p) < 0)
+ opts = qemu_opts_parse(&qemu_net_opts, p, NULL);
+ if (!opts) {
return -1;
- nd_table[nic].model = qemu_strdup("usb");
- dev = usb_net_init(&nd_table[nic]);
+ }
+
+ qemu_opt_set(opts, "type", "nic");
+ qemu_opt_set(opts, "model", "usb");
+
+ idx = net_client_init_from_opts(NULL, opts);
+ if (idx == -1) {
+ return -1;
+ }
+
+ dev = usb_net_init(&nd_table[idx]);
} else if (!strcmp(devname, "bt") || strstart(devname, "bt:", &p)) {
dev = usb_bt_init(devname[2] ? hci_init(p) :
bt_new_hci(qemu_find_bt_vlan(0)));
--
1.6.2.5
- [Qemu-devel] [PATCH] Add qemu_opts_validate() for post parsing validation, (continued)
- [Qemu-devel] [PATCH] Add qemu_opts_validate() for post parsing validation, Mark McLoughlin, 2009/10/06
- [Qemu-devel] [PATCH] Make net_client_init() consume slirp_configs even on error, Mark McLoughlin, 2009/10/06
- [Qemu-devel] [PATCH] Remove bogus error message from qemu_opts_set(), Mark McLoughlin, 2009/10/06
- [Qemu-devel] [PATCH] Remove double error message in qemu_option_set(), Mark McLoughlin, 2009/10/06
- [Qemu-devel] [PATCH] Drop config_error(), use qemu_error() instead, Mark McLoughlin, 2009/10/06
- [Qemu-devel] [PATCH] Final net cleanup after conversion to QemuOpts, Mark McLoughlin, 2009/10/06
- [Qemu-devel] [PATCH] Remove double error message for -device option parsing, Mark McLoughlin, 2009/10/06
- [Qemu-devel] [PATCH] Never overwrite a QemuOpt, Mark McLoughlin, 2009/10/06
- [Qemu-devel] [PATCH] Port -net vde to QemuOpts, Mark McLoughlin, 2009/10/06
- [Qemu-devel] [PATCH] Port -net tap to QemuOpts, Mark McLoughlin, 2009/10/06
- [Qemu-devel] [PATCH] Port usb net to QemuOpts,
Mark McLoughlin <=
- [Qemu-devel] [PATCH] Add qemu_net_opts, Mark McLoughlin, 2009/10/06
- [Qemu-devel] [PATCH] Port -net user to QemuOpts, Mark McLoughlin, 2009/10/06
- [Qemu-devel] [PATCH] Clean up legacy code in net_client_init(), Mark McLoughlin, 2009/10/06
- [Qemu-devel] [PATCH] Port host_net_add monitor command to QemuOpts, Mark McLoughlin, 2009/10/06
- [Qemu-devel] [PATCH] Port -net dump to QemuOpts, Mark McLoughlin, 2009/10/06
- [Qemu-devel] [PATCH] Port -net socket to QemuOpts, Mark McLoughlin, 2009/10/06
- [Qemu-devel] [PATCH] Port PCI NIC hotplug to QemuOpts, Mark McLoughlin, 2009/10/06
- [Qemu-devel] [PATCH] Port -net none and -net nic to QemuOpts, Mark McLoughlin, 2009/10/06