[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RfC PATCH v2 0/5] qdev-ify network cards
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [RfC PATCH v2 0/5] qdev-ify network cards |
Date: |
Wed, 7 Oct 2009 14:36:31 +0200 |
Hi,
Short RfC patch series to get the discussion rolling. We really need to
get the nic drivers qdev-ified properly, so qemu stops segfaulting on
'-device $any_nic_here'.
New in v2:
* Fix some style nits and minor issues from review.
* Don't hook up the nic to vlan 0 by default, in preparation to
other ways coming to hook up nics.
* Add pxe property for option rom loading.
To keep things small simple I've started with the ne2k_isa. All the PCI
nics share the initialization path and thus I can't simply pick a single
one as example and convert it.
The network card can now be created using ...
-device ne2k_isa,mac=00:11:22:33:44:55,vlan=1,irq=3,id=foo
'info qtree' shows ...
[ ... ]
bus: isa.0
type ISA
dev: ne2k_isa, id "foo"
dev-prop: iobase = 0x300
dev-prop: irq = 3
dev-prop: vlan = 1
dev-prop: mac = 00:11:22:33:44:55
dev-prop: pxe = 0
[ ... ]
'info network' shows:
[ ... ]
VLAN 1 devices:
foo: model=ne2k_isa,macaddr=00:11:22:33:44:55
With a vlan specified the nic initialization code calls
qemu_new_vlan_client() with the vlan specified using the vlan property.
Likewise the device cleanup code should call qemu_del_vlan_client. You
don't see that in the patches though as ISA devices are not
hot-pluggable ;)
struct NICInfo is not needed at all here. I hope we can kill it long-term.
This patch series is also available here:
http://git.et.redhat.com/?p=qemu-kraxel.git;a=shortlog;h=refs/heads/nic.v2
cheers,
Gerd
- [Qemu-devel] [RfC PATCH v2 0/5] qdev-ify network cards,
Gerd Hoffmann <=
- [Qemu-devel] [RFC PATCH v2 4/5] ne2k_isa: qdev-ify., Gerd Hoffmann, 2009/10/07
- [Qemu-devel] [RFC PATCH v2 5/5] ne2k_isa: add property for option rom loading., Gerd Hoffmann, 2009/10/07
- Re: [Qemu-devel] [RFC PATCH v2 5/5] ne2k_isa: add property for option rom loading., Anthony Liguori, 2009/10/07
- Re: [Qemu-devel] [RFC PATCH v2 5/5] ne2k_isa: add property for option rom loading., Gerd Hoffmann, 2009/10/07
- Re: [Qemu-devel] [RFC PATCH v2 5/5] ne2k_isa: add property for option rom loading., Anthony Liguori, 2009/10/07
- Re: [Qemu-devel] [RFC PATCH v2 5/5] ne2k_isa: add property for option rom loading., Gerd Hoffmann, 2009/10/07
- Re: [Qemu-devel] [RFC PATCH v2 5/5] ne2k_isa: add property for option rom loading., Anthony Liguori, 2009/10/07
- Re: [Qemu-devel] [RFC PATCH v2 5/5] ne2k_isa: add property for option rom loading., Gerd Hoffmann, 2009/10/07