[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 04/15] monitor: Add user_print() to mon_cmd_t
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] Re: [PATCH 04/15] monitor: Add user_print() to mon_cmd_t |
Date: |
Wed, 7 Oct 2009 09:52:43 -0300 |
On Tue, 06 Oct 2009 20:40:31 -0500
Anthony Liguori <address@hidden> wrote:
> Luiz Capitulino wrote:
> > This new struct member will store a pointer to a function that
> > should be used to output data in the user protocol format.
> >
> > It will also serve as a flag to say if a given handler has already
> > been converted to the new QObject style.
> >
> > Additionally, this commit converts mon_cmd_t static initializations
> > to the C99 way.
> >
>
> This should really be two patches. One that does the mon_cmd_t init
> conversion and then another that introduces user_print. This would be
> easier if...
Ok, will split.
> <snip>
> > + {
> > + .name = "version",
> > + .args_type = "",
> > + .handler = do_info_version,
> > + .user_print = NULL,
> > + .params = "",
> > + .help = "show the version of QEMU"
> > + },
> >
>
> You didn't explicitly initialize things to NULL and made sure that
> args_types = "" worked the same as args_type = NULL (and likewise for
> params. This would help de-uglify what's happening in this file :-)
I think this work is part of the patch series which will change
args_type to be an array, as suggested by Markus.
This is series is just an initial help.
- [Qemu-devel] [PATCH v2 00/15]: Initial QObject conversion, Luiz Capitulino, 2009/10/06
- [Qemu-devel] [PATCH 02/15] Introduce QList, Luiz Capitulino, 2009/10/06
- [Qemu-devel] [PATCH 01/15] QObject: Accept NULL, Luiz Capitulino, 2009/10/06
- [Qemu-devel] [PATCH 03/15] Introduce QList unit-tests, Luiz Capitulino, 2009/10/06
- [Qemu-devel] [PATCH 04/15] monitor: Add user_print() to mon_cmd_t, Luiz Capitulino, 2009/10/06
- [Qemu-devel] [PATCH 05/15] monitor: Handle new and old style handlers, Luiz Capitulino, 2009/10/06
- [Qemu-devel] [PATCH 06/15] monitor: do_info(): handle new and old info handlers, Luiz Capitulino, 2009/10/06
- [Qemu-devel] [PATCH 07/15] monitor: Convert do_quit() do QObject, Luiz Capitulino, 2009/10/06
- [Qemu-devel] [PATCH 08/15] monitor: Convert do_stop() to QObject, Luiz Capitulino, 2009/10/06
- [Qemu-devel] [PATCH 09/15] monitor: Convert do_system_reset() to QObject, Luiz Capitulino, 2009/10/06
- [Qemu-devel] [PATCH 10/15] monitor: Convert do_system_powerdown() to QObject, Luiz Capitulino, 2009/10/06
- [Qemu-devel] [PATCH 11/15] monitor: Convert do_cont() to QObject, Luiz Capitulino, 2009/10/06
- [Qemu-devel] [PATCH 12/15] monitor: Convert do_balloon() to QObject, Luiz Capitulino, 2009/10/06