[Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread"

[malc]

On Wed, 7 Oct 2009, Michael S. Tsirkin wrote:

> This reverts commit ee3993069ff55fa6f1c64daf1e09963e340db8e4.
> 
> With commit ee3993069ff55fa6f1c64daf1e09963e340db8e4,
> winxp installation on a raw format file fails
> during disk format, with a message "your
> disk may be damaged".
> 
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> Cc: malc <address@hidden>
> ---
> 
> malc, care to describe what the problem you
> are solving here is?

New thread is spawned, SIGALRM arrives, kernel picks up this new thread
since it's mask allows it - bad thigs happen.

> 
> All, could everyone please start being nice and post patches
> and give time for review before applying?
> Thanks!

There's nothing to review in this particular case, the thing was plain
broken, besides same thing was already discussed between me and
Andrzej, see for instance:
http://www.mail-archive.com/address@hidden/msg09542.html

Needless to say the revert is broken also.

-- 
mailto:address@hidden