[Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread"

[Michael S. Tsirkin]

On Wed, Oct 07, 2009 at 11:28:21AM -0500, Anthony Liguori wrote:
>
>> There's nothing to review in this particular case, the thing was plain
>> broken, besides same thing was already discussed between me and
>> Andrzej, see for instance:
>> http://www.mail-archive.com/address@hidden/msg09542.html
>>
>> Needless to say the revert is broken also.
>>   
>
> Yeah, I understand the race the original commit fixes but I don't  
> understand how the original commit broke WinXP.
>
> Do you have further insight Michael?

Nope, I just bisected and then reverted and tested that this helps.

>  Blindly reverting something that  
> appears right because of a regression is likely just papering over a  
> bigger problem.
>
> Regards,
>
> Anthony Liguori
>