|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] Re: [PATCH v2 9/9] Add -kvm option |
Date: | Thu, 08 Oct 2009 09:23:14 -0500 |
User-agent: | Thunderbird 2.0.0.23 (X11/20090825) |
Avi Kivity wrote:
On 10/08/2009 01:00 AM, Anthony Liguori wrote:Glauber Costa wrote:This option deprecates --enable-kvm. It is a more flexible option,that makes use of qemu-opts, and allow us to pass on options to enable ordisable kernel irqchip, for example.With proper qdev support, you could select kvm device models based on -device so I think this option isn't all that useful.qdev (mostly?) is about the guest interface; this is more about the host implementation, so akin to -drive file= and cache=.
If we make the kvm device a separate device, then it's about choosing which device to use.
Regardless, even if it were a single device, it's still a property of the device so a qdev property would be the logical way to expose it.
What I'd like to see in the interim is a kvm specific machine type that's defaulted to if kvm is enabled. I think this would be useful not only for enabling things like in-kernel apic, but also for selecting a default cpu model.We should make a distinction between guest-visible changes and accelerators like kvm-irqchip and vhost.
They are different device models that happen to implement the same guest-visible device.
Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |