[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 0/3] qemu: reset-related fixes
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH 0/3] qemu: reset-related fixes |
Date: |
Thu, 8 Oct 2009 17:02:51 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Thu, Oct 08, 2009 at 04:52:26PM +0200, Michael S. Tsirkin wrote:
> On Wed, Oct 07, 2009 at 10:20:19AM +0200, Avi Kivity wrote:
> >> Reset BARs and a couple of other registers on bus reset, as per PCI
> >> spec.
> >>
> >
> > This commit breaks Windows XP restart. After a restart Windows switches
> > from 800x600 cirrus logic vga to 640x480 standard vga.
>
> So I think this is a bios bug. Patchset fixing this applied.
>
> So, what's the best way to propagate the fixes upstream?
> Avi, Anthony, please advise.
>
> Avi, after applying this, you need to generate a new bios binary.
>
> Anthony, qemu keeps bios binaries in source tree.
> I can't post a patch changing these, can I?
> Only people with git access can change them.
>
> BTW, can't we keep the sources around the like qemu-kvm does?
> It would be best if pc-bios used git, then we would
> include a submodule, as it is we can set up a git-cvs
> mirror at qemu site, and then include a submodule.
> Makes sense?
On this last point, it was pointed out to me that
this is what we have already. Sorry about the noise.
> Michael S. Tsirkin (3):
> pc-bios: enable io/memory unconditionally
> qemu: make cirrus init value pci spec compliant
> qemu: cleanup unused macros in cirrus
>
> hw/cirrus_vga.c | 38 +-------------------------------------
> kvm/bios/rombios32.c | 18 +++++++-----------
> 2 files changed, 8 insertions(+), 48 deletions(-)
>
> --
> MST
>
>