[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/1] net: fix multiple NICs causing net opts process
From: |
Mark McLoughlin |
Subject: |
[Qemu-devel] [PATCH 1/1] net: fix multiple NICs causing net opts process to stop |
Date: |
Mon, 12 Oct 2009 09:52:00 +0100 |
For NICs, net_init_client() returns the index into the NICInfo table.
qemu_opts_foreach() interprets non-zero as an error return an stops
iterating over the options.
So, if you have more than one '-net nic' on the command line, subsequent
'-net' options do not get processed.
Fix this by making net_client_init() only return non-zero if
net_init_client() returns an error.
Reported-by: Peter Lieven <address@hidden>
Signed-off-by: Mark McLoughlin <address@hidden>
---
net.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/net.c b/net.c
index 2e4dd58..7cee404 100644
--- a/net.c
+++ b/net.c
@@ -3203,7 +3203,9 @@ static void net_check_clients(void)
static int net_init_client(QemuOpts *opts, void *dummy)
{
- return net_client_init(NULL, opts);
+ if (net_client_init(NULL, opts) < 0)
+ return -1;
+ return 0;
}
int net_init_clients(void)
--
1.6.2.5