Re: [Qemu-devel] [PATCH] tcg, tci: Add TCG and interpreter for bytecode (virtual machine)

[malc]

On Mon, 12 Oct 2009, Stuart Brady wrote:

> On Mon, Oct 12, 2009 at 04:33:10PM +0400, malc wrote:
> > On Mon, 12 Oct 2009, Stuart Brady wrote:
> > 
> > > Huh?  If you're using a function pointer with the *correct* type,
> > > I hardly see how that's not sufficient.
> > 
> > Let me give you an example:
> > 
> [snip]
> 
> *Mind boggles* :-)
> 
> You seem to be ignoring the words "correct type" in all of my sentences.
> My suggestion was to give op_call handling the information it that needs
> iff TCI is used.  Yes, the code in tcg_gen_callN() is clearly not
> appropriate for TCI, although I'd somehow missed the fact that it may
> also need to be changed in future to support other new TCG back-ends.
> 
> I'm quite aware that functions must be invoked using the *correct type*
> of function pointer, though.  Perhaps I wasn't specific enough in what
> I said, but please, I'm not completely clueless... :-)

Are you thinking of a giant switch here, or what?

-- 
mailto:address@hidden