Re: [Qemu-devel] Re: [PATCH 01/10] Introduce qmisc module

qemu-devel

From:	Paolo Bonzini
Subject:	Re: [Qemu-devel] Re: [PATCH 01/10] Introduce qmisc module
Date:	Sat, 17 Oct 2009 02:46:05 +0200
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4

On 10/17/2009 02:38 AM, malc wrote:

a. allocation can fail


s/malloc/qemu_malloc/ etc. when it is time to merge.

b. strtod is locale dependent

Right, but qemu probably would prefer to always do setlocale(LC_NUMERIC, "C"), or add a c_strtod function like


http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=blob_plain;f=lib/c-strtod.c

Thanks for the review, any additional pair of eyes can only help.

Paolo

Current Thread

[Next in Thread]