|
From: | Paolo Bonzini |
Subject: | [Qemu-devel] Re: [PATCH 01/10] Introduce qmisc module |
Date: | Sat, 17 Oct 2009 09:48:17 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4 |
On 10/17/2009 03:50 AM, Anthony Liguori wrote:
Paolo Bonzini wrote:On 10/16/2009 11:37 PM, Anthony Liguori wrote:I already am :-) Stay tuned, I should have a patch later this afternoon.Was it a race? (Seriously, sorry I didn't notice a couple of hours ago). This one is ~5% slower than the "Evil" one, but half the size. Tested against the comments.json file from the "Evil" parser and with valgrind too. Does all the funky Unicode stuff too.I haven't benchmarked mine. While yours came out an hour earlier, I included a full test suite, output QObjects, and support vararg parsing so I think I win :-)
Heh, Luiz and I had talked offlist and he'd take care of the rest (except the test suite) :-).
> Having an explicit stack is unnecessary I think.I'm curious to see yours now---the stack is used to detect things like [{"a":"b"},"c":"d"]. You could do that in the event handlers of course, but that kind of breaks the interface between the parser and event handlers.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |