RE: [Qemu-devel] qemu-0.11.50 build breaks at monitor.c

[Laurent Vivier]

>Hi Marcelo,
>
>       qemu-0.11.50 build breaks with 
>
>CC    x86_64-softmmu/monitor.o
>cc1: warnings being treated as errors
>/other/srcs/qemu-kvm/monitor.c: In function 'print_cpu_iter':
>/other/srcs/qemu-kvm/monitor.c:450: error: format '%ld' expects type 'long 
>int', but argument 3 has type 'int64_t'
>make[3]: *** [monitor.o] Error 1
>
>Changes to print_cpu_iter was introduced by 
>
>commit 00ee594280d46290629ccd5fcd1b5c1a21605e4c
>Author: Marcelo Tosatti <address@hidden>
>Date:   Wed Oct 14 19:21:10 2009 -0300
>
>    Add missing thread_id field in "info cpus"
>
>typecasting it int long, helps
>
> monitor.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/monitor.c b/monitor.c
>index b4c4878..5416fdb 100644
>--- a/monitor.c
>+++ b/monitor.c
>@@ -447,7 +447,7 @@ static void print_cpu_iter(QObject *obj, void *opaque)
>     if (strcmp(qdict_get_str(cpu, "halted"), "yes") == 0)
>         monitor_printf(mon, " (halted)");
> 
>-    monitor_printf(mon, " thread_id=%ld", qdict_get_int(cpu, "thread_id"));
>+    monitor_printf(mon, " thread_id=%ld", (int long)qdict_get_int(cpu, 
>"thread_id"));

You should use %PRId64 instead of %ld.

Regards,
Laurent
-- 
--------------------- address@hidden  ---------------------
"Tout ce qui est impossible reste à accomplir"    Jules Verne
"Things are only impossible until they're not" Jean-Luc Picard