[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus,
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports |
Date: |
Tue, 20 Oct 2009 17:31:23 +0530 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On (Tue) Oct 20 2009 [12:08:06], Richard W.M. Jones wrote:
> On Tue, Oct 20, 2009 at 12:43:44PM +0530, Amit Shah wrote:
> > DEF("virtioconsole", HAS_ARG, QEMU_OPTION_virtiocon, \
> > "-virtioconsole c\n" \
> > - " set virtio console\n")
> > + " define virtio console\n")
>
> It would be much better to add a detectable string here so we
> (libguestfs) can tell if multiport is supported. Something like:
>
> " set virtio console (multiport)\n"
How about (deprecated)? (We need to have this in some general policy of
deprecating command-line options.)
> > STEXI
> > @item -virtioconsole @var{c}
> > Set virtio console.
> > +
> > +This option is maintained for backward compatibility.
> > +
> > +Please use @code{-device virtioconsole} for the new way of invocation
>
> I think you mean -device virtconsole here.
Yeah; thanks. Will fix.
Amit
- [Qemu-devel] [PATCH v9 0/3] virtio-console: Add support for multiple ports for generic guest-host communication, Amit Shah, 2009/10/20
- [Qemu-devel] [PATCH v9 1/3] qdev: add string property., Amit Shah, 2009/10/20
- [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports, Amit Shah, 2009/10/20
- [Qemu-devel] [PATCH v9 3/3] virtio-console: Add a new virtserialport device for generic serial port support, Amit Shah, 2009/10/20
- Re: [Qemu-devel] [PATCH v9 3/3] virtio-console: Add a new virtserialport device for generic serial port support, Gerd Hoffmann, 2009/10/20
- Re: [Qemu-devel] [PATCH v9 3/3] virtio-console: Add a new virtserialport device for generic serial port support, Amit Shah, 2009/10/20
- Re: [Qemu-devel] [PATCH v9 3/3] virtio-console: Add a new virtserialport device for generic serial port support, Gerd Hoffmann, 2009/10/20
- Re: [Qemu-devel] [PATCH v9 3/3] virtio-console: Add a new virtserialport device for generic serial port support, Amit Shah, 2009/10/20
- Re: [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports, Gerd Hoffmann, 2009/10/20
- Re: [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports, Richard W.M. Jones, 2009/10/20
- Re: [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports,
Amit Shah <=
- Re: [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports, Richard W.M. Jones, 2009/10/20
- Re: [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports, Amit Shah, 2009/10/20
Re: [Qemu-devel] [PATCH v9 0/3] virtio-console: Add support for multiple ports for generic guest-host communication, Gerd Hoffmann, 2009/10/20
Re: [Qemu-devel] [PATCH v9 0/3] virtio-console: Add support for multiple ports for generic guest-host communication, Dor Laor, 2009/10/20