qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus,


From: Amit Shah
Subject: Re: [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports
Date: Tue, 20 Oct 2009 17:46:59 +0530
User-agent: Mutt/1.5.19 (2009-01-05)

On (Tue) Oct 20 2009 [13:05:59], Richard W.M. Jones wrote:
> On Tue, Oct 20, 2009 at 05:31:23PM +0530, Amit Shah wrote:
> > How about (deprecated)? (We need to have this in some general policy of
> > deprecating command-line options.)
> 
> No, the important thing is that we can detect somehow that multiport
> virtio console is possible for some random version of qemu that we
> have to work with.
>
> The only feasible way we've been able to discover is to poke qemu with
> various arguments (usually, "qemu -help") and then match on substrings
> in the output.

Hm, probing with -device '?' will get you the new devices:

-device virtio-serial-pci and -device virtserialport are two new devices
added (along with -device virtconsole). 

> If there's a better way to do this, please let me know.

I'm not sure of that, but there should be.

> But for now, having "(multiport)" there allows us to detect that
> multiport virtio console is supported.

But suggesting -virtioconsole supports multiport is misleading and
further usage of -virtioconsole is not to be encouraged as well..

> > > I think you mean -device virtconsole here.
> > 
> > Yeah; thanks. Will fix.
> 
> So is this documentation correct or not?
> 
>   http://www.linux-kvm.org/page/VMchannel_Requirements#Invocation

Yes, that's updated very recently and is according to what we have now.

                Amit




reply via email to

[Prev in Thread] Current Thread [Next in Thread]