Re: [Qemu-devel] [PATCH v9 3/3] virtio-console: Add a new virtserialport device for generic serial port support

[Gerd Hoffmann]

On 10/20/09 11:48, Amit Shah wrote:
> On (Tue) Oct 20 2009 [10:51:30], Gerd Hoffmann wrote:
> > > @@ -107,3 +107,41 @@ static void virtcon_register(void)
> > >        virtio_serial_port_qdev_register(&virtcon_info);
> > >    }
> > >    device_init(virtcon_register)
> >
> > > +static VirtIOSerialPortInfo virtserial_port_info = {
> > > +    .qdev.name     = "virtserialport",
> > > +    .qdev.size     = sizeof(VirtConsole),
> > > +    .init          = virtserial_port_initfn,
> > > +    .have_data     = flush_buf,
> > > +    .qdev.props = (Property[]) {
> > > +        DEFINE_PROP_CHR("chardev", VirtConsole, chr),
> > > +        DEFINE_PROP_STRING("name", VirtIOSerialPort, name),
> >
> > likewise: DEFINE_PROP_STRING("name", VirtConsole, port.name),
>
> The 'name' field is common to all ports, so it makes sense to put it in
> the VirtIOSerialPort struct. (Internal users can pre-define it to their
> liking, eg, org.qemu.vnc)

Sure.  I don't want to move it out there.  But the driver state struct 
is 'VirtConsole' so all properties should use that.  Note that the field 
changed too: from "name" to "port.name", so everything keeps working ;)

cheers,
  Gerd