Re: [Qemu-devel] [PATCH 1/9] Export function for VA defined ram allocation

[Alexander Graf]

On 21.10.2009, at 20:06, Anthony Liguori wrote:

> Alexander Graf wrote:
> > So you would prefer a special #ifdef for s390 in generic code over  
> > a specifically for this purpose exported function?
> >
> > Well, you're the boss. I like the special function better, but  
> > whatever you say.
>
> How is someone supposed to figure out what _qemu_ram_alloc is for?   
> Nothing in your patch really indicates that.
>
> However, an ugly #ifdef immediately tells someone, oh, s390 kvm  
> needs this terrible hack, so let's keep bugging those guys to  
> eliminate the need for that.

Alright :-). Any other complaints? If not I'd spin up v3.

Alex