Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers

[Glauber Costa]

On Wed, Oct 21, 2009 at 04:52:00PM +0200, Gerd Hoffmann wrote:
> On 10/21/09 16:32, Glauber Costa wrote:
>> On Wed, Oct 21, 2009 at 03:38:31PM +0200, Gerd Hoffmann wrote:
>>> On 10/20/09 16:04, Glauber Costa wrote:
>>>> Currently, the msrs involved in setting up pvclock are not saved over
>>>> migration and/or save/restore. This patch puts their value in special
>>>> fields in our CPUState, and deal with them using vmstate.
>>>>
>>>> kvm also has to account for it, by including them in the msr list
>>>> for the ioctls.
>>>
>>> Fails to build.  Fedora 11 machine with distro kernel.
>>>
>>> http://repo.or.cz/w/qemu/pdb.git?a=blob;f=build.log;h=5b8a2e83116dc6a74e5045e30c3efe71fa7397ef;hb=0b4f913c89b89b45d3844dc1cf321e3d94871ecb
>> strange message. Do we need --kerneldir for that?
>
> Requiring --kerneldir for a successful build isn't going to fly.
>
>> kvm_para.h should be available...
>
> Nope:
>
>    $ rpm -ql kernel-headers | grep kvm
>    /usr/include/asm/kvm.h
>    /usr/include/linux/kvm.h
>
> Did you ever build this?
> You should improve your patch qa ...
btw, it builds fine for me even without --kerneldir, just tested.

and the <linux/kvm_para.h> include is there since Feb08, a while now.

/me wonders what the heck is going on...