[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers
From: |
Glauber Costa |
Subject: |
Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers |
Date: |
Thu, 22 Oct 2009 09:23:27 -0200 |
User-agent: |
Jack Bauer |
On Thu, Oct 22, 2009 at 10:00:37AM +0200, Gerd Hoffmann wrote:
> On 10/21/09 21:39, Glauber Costa wrote:
>>> $ rpm -ql kernel-headers | grep kvm
>>> /usr/include/asm/kvm.h
>>> /usr/include/linux/kvm.h
>>>
>>> Did you ever build this?
>>> You should improve your patch qa ...
>> btw, it builds fine for me even without --kerneldir, just tested.
>>
>> and the<linux/kvm_para.h> include is there since Feb08, a while now.
>
> Which doesn't imply "make headers" actually includes that file. Even
> rawhide aka soon-to-be-F12 ships no kvm_para.h header file in
> kernel-headers.
>
> Just defining the msrs instead of using kvm_para.h should be fine, the
> numbers will not change ...
That's not the problem. If one removes kvm_para.h, a lot of other things
will not build. For example, the capabilities list.
And it has been like this for almost a year now!
Without that header, your system should have never successfully built a
qemu-kvm instance. This is what happens here, if I try to remove it:
error: ‘KVM_FEATURE_CLOCKSOURCE’ undeclared here (not in a function)
error: ‘KVM_FEATURE_NOP_IO_DELAY’ undeclared here (not in a function)
error: ‘KVM_FEATURE_MMU_OP’ undeclared here (not in a function)
So again, wth?
- [Qemu-devel] [PATCH] properly save kvm system time msr registers, Glauber Costa, 2009/10/20
- Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers, Gerd Hoffmann, 2009/10/21
- Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers, Glauber Costa, 2009/10/21
- Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers, Gerd Hoffmann, 2009/10/21
- Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers, Glauber Costa, 2009/10/21
- Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers, Glauber Costa, 2009/10/21
- Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers, Gerd Hoffmann, 2009/10/22
- Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers,
Glauber Costa <=
- Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers, Gerd Hoffmann, 2009/10/22
- Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers, Glauber Costa, 2009/10/22
- Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers, Glauber Costa, 2009/10/22
- Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers, Anthony Liguori, 2009/10/22