[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only whe
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened |
Date: |
Mon, 26 Oct 2009 09:23:12 +0530 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On (Sat) Oct 24 2009 [12:36:54], Jan Kiszka wrote:
> Amit Shah wrote:
> > The OPENED event gets sent also when qemu resets its state initially.
> > The consumers of the event aren't interested in receiving this event
> > on reset.
>
> The monitor was. Now its initial prompt on activation is broken.
The patch in Anthony's queue, titled
'console: call qemu_chr_reset() in text_console_init'
fixed that.
However, with the qcow2 synchronous patch, the monitor prompt doesn't
come up again -- which shows there is a problem with the way the bhs
work and also the initial resets.
I think the initial resets are a hack to work around something from my
reading of it; do you have a better idea of why it's there and how it's
all supposed to work?
> Does this patch fix/improve something for a different user? If not,
> please let us revert it.
There's another question too: is a separate 'reset' event needed in
addition to an 'opened' event?
I have a few apps (that are coming as part of the virtio-console work)
that need just an 'opened' event and are not interested in the 'reset'
event.
Amit
- [Qemu-devel] [PATCH v2 0/3] Send out OPENED events only on chardev open, Amit Shah, 2009/10/07
- [Qemu-devel] [PATCH v2 1/3] char: check for initial_reset_issued unnecessary, Amit Shah, 2009/10/07
- [Qemu-devel] [PATCH v2 2/3] char: rename CHR_EVENT_RESET to CHR_EVENT_OPENED, Amit Shah, 2009/10/07
- [Qemu-devel] [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Amit Shah, 2009/10/07
- [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Jan Kiszka, 2009/10/24
- Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened,
Amit Shah <=
- Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Jan Kiszka, 2009/10/26
- Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Amit Shah, 2009/10/26
- Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Jan Kiszka, 2009/10/26
- Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Amit Shah, 2009/10/27
- Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Kevin Wolf, 2009/10/27
- Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Amit Shah, 2009/10/27
- Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Anthony Liguori, 2009/10/27
- Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Amit Shah, 2009/10/27
- Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Kevin Wolf, 2009/10/27