[Qemu-devel] Re: [PATCH] raw/linux-aio: Also initialize POSIX AIO

[Kevin Wolf]

Am 25.10.2009 08:19, schrieb Christoph Hellwig:
> On Thu, Oct 22, 2009 at 11:05:55AM +0200, Kevin Wolf wrote:
>> Yes, it might look like overkill to introduce a abstraction for exactly
>> two backends. I felt the same way. But then, the current implementation
>> just feels totally wrong. It absolutely intransparent when we fall back
>> to paio, and before debugging the bdrv_read/write emulation I didn't
>> even know that we're doing it. And, like I said, why should a block
>> format driver know what AIO method works which way?
> 
> Because the aio method is part of the block driver.  Despite our
> code organization linux-aio.c and compat-posix-aio.c aren't generic
> abstractions but sub-modules of raw-posix.

Well, my question was not if they are sub-modules of raw-posix - they
clearly are - but rather if they should be.

But ok, I'll just submit a patch drop the context parameter in paio_* then.

Kevin