[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/10] target-arm: optimize vfp load/store mu
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/10] target-arm: optimize vfp load/store multiple ops |
Date: |
Tue, 27 Oct 2009 09:42:12 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Sat, Oct 24, 2009 at 03:19:03PM +0300, address@hidden wrote:
> From: Juha Riihimäki <address@hidden>
>
> VFP load/store multiple instructions can be slightly optimized by
> loading the register offset constant into a variable outside the
> register loop and using the preloaded variable inside the loop instead
> of reloading the offset value to a temporary variable on each loop
> iteration. This causes less TCG ops to be generated for a VFP load/
> store multiple instruction if there are more than one register
> accessed, otherwise the amount of generated TCG ops is the same.
Same for this patch, it should not change the generated host code, so I
am not sure it really worth it.
> Signed-off-by: Juha Riihimäki <address@hidden>
> ---
> target-arm/translate.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 8cb1c0f..38fb833 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -3222,6 +3222,7 @@ static int disas_vfp_insn(CPUState * env, DisasContext
> *s, uint32_t insn)
> offset = 8;
> else
> offset = 4;
> + tmp = tcg_const_i32(offset);
> for (i = 0; i < n; i++) {
> if (insn & ARM_CP_RW_BIT) {
> /* load */
> @@ -3232,8 +3233,9 @@ static int disas_vfp_insn(CPUState * env, DisasContext
> *s, uint32_t insn)
> gen_mov_F0_vreg(dp, rd + i);
> gen_vfp_st(s, dp, addr);
> }
> - tcg_gen_addi_i32(addr, addr, offset);
> + tcg_gen_add_i32(addr, addr, tmp);
> }
> + tcg_temp_free_i32(tmp);
> if (insn & (1 << 21)) {
> /* writeback */
> if (insn & (1 << 24))
> --
> 1.6.5
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- Re: [Qemu-devel] [PATCH v2 09/10] target-arm: optimize neon vld/vst ops, (continued)
[Qemu-devel] [PATCH v2 06/10] target-arm: fix neon vsri, vshl and vsli ops, juha . riihimaki, 2009/10/24
[Qemu-devel] [PATCH v2 10/10] target-arm: fix neon shift helper functions, juha . riihimaki, 2009/10/24
[Qemu-devel] [PATCH v2 04/10] target-arm: optimize vfp load/store multiple ops, juha . riihimaki, 2009/10/24
[Qemu-devel] [PATCH v2 08/10] target-arm: optimize thumb push/pop ops, juha . riihimaki, 2009/10/24
Re: [Qemu-devel] [PATCH v2 00/10] target-arm: miscellaneous fixes, Aurelien Jarno, 2009/10/25