qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 0/5] Fix packet queueing to allow full tap queue


From: Scott Tsai
Subject: [Qemu-devel] Re: [PATCH 0/5] Fix packet queueing to allow full tap queue drain
Date: Wed, 28 Oct 2009 11:36:11 +0800
User-agent: Sup/0.9

>         Scott, Sven, if you could test the tap-drain-queue branch from
> my tree, that would be great:
>   http://repo.or.cz/w/qemu/markmc.git
> 
> Thanks,
> Mark. 

Mark,
I've tested http://repo.or.cz/w/qemu/markmc.git and it indeed works for my test 
case
(NFS through emulated smc91c111 NIC on arm-integragorcp)

How about adding a comment in tap_send() about when qemu_send_packet_async() 
would return 0 and -1?

I'd also recommend checking for the case of qemu_send_packet_async() returning 
-1 and dropping a packet
and have a debug message guarded by #ifdef DEBUG_TAP in case the 
qemu_can_send_packet() check
is ever removed in future modifications of the code.

Also, would it be possible to get the stable-0.11 version of the patch into the 
soon to be released Fedora 12?
I've written some embedded Linux tutorials for Taiwanese consumer electronics 
developers that recommends using qemu
on Fedora. Being able to rely on NFS always working in Fedora's qmeu packet 
would really help :)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]