[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 07/10] ac97: sizeof returns unsigned long
From: |
malc |
Subject: |
Re: [Qemu-devel] Re: [PATCH 07/10] ac97: sizeof returns unsigned long |
Date: |
Wed, 28 Oct 2009 19:25:52 +0300 (MSK) |
On Wed, 28 Oct 2009, Paolo Bonzini wrote:
> On 10/28/2009 04:41 PM, malc wrote:
> > > > > > sizeof returns size_t (%zX), so this is wrong
> > > >
> > > > size_t is long on all practical platforms except ia64-hpux and Win64,
> > > so this
> > > > is not more wrong than it was before.
> > Yea right, except that's it's not long on any 32bit platform, at least not
> > from gcc's -Wformat point of view.
>
> Still an improvement (wrong code vs. warning)... you are a committer,
> you can fix it yourself if it bothers you...
It's wrong code vs wrong code on Win64 and a warning equals failed build
in presence of -Werror.
--
mailto:address@hidden
[Qemu-devel] [PATCH 08/10] ac97: recalculate active after loadvm, Juan Quintela, 2009/10/28
[Qemu-devel] [PATCH 09/10] ac97: up savevm version and remove active from state, Juan Quintela, 2009/10/28
[Qemu-devel] [PATCH 10/10] ac97: port to vmstate, Juan Quintela, 2009/10/28
[Qemu-devel] [PATCH 03/10] sb16: port to vmstate, Juan Quintela, 2009/10/28
[Qemu-devel] [PATCH 05/10] c4231a: port to vmstate, Juan Quintela, 2009/10/28
[Qemu-devel] [PATCH 02/10] audio: port to vmstate, Juan Quintela, 2009/10/28
[Qemu-devel] [PATCH 01/10] audio: fix compilation of DEBUG_PLIVE, Juan Quintela, 2009/10/28
[Qemu-devel] [PATCH 04/10] es1370: port to vmstate, Juan Quintela, 2009/10/28